add std.atomic.Op for feature detection #24548
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silversquirl
force-pushed
the
atomic_feature_detection
branch
4 times, most recently
from
4eb8efd to
02c7ba7
Compare
silversquirl
force-pushed
the
atomic_feature_detection
branch
from
97d4c08 to
d3a1085
Compare
silversquirl
force-pushed
the
atomic_feature_detection
branch
from
d3a1085 to
55876b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #24528
@andrewrk how's this? :)
I've not reviewed the logic for most targets - it's just copied across verbatim - but I did go through wasm fairly thoroughly, and I added a feature detection for x86 cx8 (equivalent of cx16 on x86_64)
I wasn't entirely sure whether to put this in
std.atomicorstd.Target- let me know your thoughts!